Do not disable stats via procfs if already enabled #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haze
approved these changes
Apr 24, 2024
etungsten
approved these changes
Apr 24, 2024
Co-authored-by: haze <isnt@haze.cool>
casualjim
reviewed
Apr 24, 2024
casualjim
approved these changes
Apr 24, 2024
jasonk000
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user is using bpftop on a kernel older than 5.8, we will attempt to enable BPF stats globally using the procfs file
/proc/sys/kernel/bpf_stats_enabled. With this change, we will only enable BPF stats via procfs if they are not already active. Thus, we will not modify the settings upon exit if the stats were previously enabled. This change ensures we do not deactivate BPF stats at shutdown if they were already turned on by the user before running bpftop.I also did refactoring to make this logic easier to read.