Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

UI stop working when selecting one task of a DAG #3330

Open
marcocrasso opened this issue Nov 1, 2022 · 3 comments
Open

UI stop working when selecting one task of a DAG #3330

marcocrasso opened this issue Nov 1, 2022 · 3 comments
Labels
type: bug bugs/ bug fixes

Comments

@marcocrasso
Copy link
Contributor

Describe the bug
The UI stop working when selecting one task of a DAG with Safari. In the past, one click on a task displayed tasks details pane on the right side of the screen.

Details

  • Conductor UI v3.13.2
  • Safari Version 15.6.1 (15613.3.9.1.16, 15613)

The server is not related to the issue.

To Reproduce
Steps to reproduce the behavior:

git fetch
git checkout v3.13.2
cd ui
export WF_SERVER=<<your server with api, e.g. https://localhost:8080/>>
yarn build
yarn start
go to http://localhost:5000/ and pick one executed workflow, then click on one green task. That doesn't work for us.

Expected behavior
When you click a task, the right pane you be there with task details.

Screenshots
image

Additional context
Add any other context about the problem here.
@marcocrasso marcocrasso added the type: bug bugs/ bug fixes label Nov 1, 2022
@agustincas
Copy link

Has anyone had a chance to try and reproduce this issue?

ceisen1 added a commit to ceisen1/conductor that referenced this issue Jan 23, 2023
@ceisen1
Task details not showing in UI
6347162 
Event.path is deprecated in chrome as of the last update https://chromestatus.com/feature/5726124632965120. This is causing a bug when clicking on a task in the UI. This is also see in safari: Netflix#3330. Updating to use composedPath() instead per guidance.

This is compatible with all browsers:
https://developer.mozilla.org/en-US/docs/Web/API/Event/composedPath
@ceisen1 ceisen1 mentioned this issue Jan 23, 2023
Merged
6 tasks
@ceisen1
Copy link
Contributor

ceisen1 commented Jan 23, 2023

I added a fix for this issue here #3459

@marcocrasso
Copy link
Contributor Author

Hi @aravindanr
could you please assign a reviewer to this #3459 when you have chance?
This will be really appreciated. Thanks in advance.

@marcocrasso marcocrasso reopened this Jan 24, 2023
peterlau pushed a commit that referenced this issue Jan 26, 2023
@ceisen1 @peterlau
Task details not showing in UI
eba3fc3 
Event.path is deprecated in chrome as of the last update https://chromestatus.com/feature/5726124632965120. This is causing a bug when clicking on a task in the UI. This is also see in safari: #3330. Updating to use composedPath() instead per guidance.

This is compatible with all browsers:
https://developer.mozilla.org/en-US/docs/Web/API/Event/composedPath
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug bugs/ bug fixes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@agustincas @marcocrasso @ceisen1