Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

1696: correct task seq in DO_WHILE #1815

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Conversation

alex-fu
Copy link
Contributor

@alex-fu alex-fu commented Aug 2, 2020

Found the same issue in #1696

Tasks in DO_WHILE task was not shown in conductor-ui. I found it's because DoWhile.execute() use a copy of workflow, and the tasks' seq in the copied workflow was not assigned.

I add the assignation of seq in Task.deepCopy() and the seq of tasks in DO_WHILE task appears in UI.

@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #1815 into dev will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1815      +/-   ##
============================================
- Coverage     64.70%   64.61%   -0.10%     
+ Complexity     3796     3791       -5     
============================================
  Files           295      295              
  Lines         18092    18093       +1     
  Branches       1627     1627              
============================================
- Hits          11706    11690      -16     
- Misses         5567     5584      +17     
  Partials        819      819              
Impacted Files Coverage Δ Complexity Δ
.../netflix/conductor/common/metadata/tasks/Task.java 82.71% <100.00%> (+0.07%) 102.00 <0.00> (ø)
...ix/conductor/dao/postgres/PostgresMetadataDAO.java 76.11% <0.00%> (-5.56%) 63.00% <0.00%> (-3.00%)
...tflix/conductor/dao/postgres/PostgresQueueDAO.java 87.71% <0.00%> (-3.51%) 48.00% <0.00%> (-1.00%)
.../conductor/dao/cassandra/CassandraMetadataDAO.java 53.88% <0.00%> (-1.56%) 24.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a98028...ddc4381. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4404

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 17 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 69.17%

Files with Coverage Reduction New Missed Lines %
cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java 2 55.44%
postgres-persistence/src/main/java/com/netflix/conductor/dao/postgres/PostgresQueueDAO.java 4 92.11%
postgres-persistence/src/main/java/com/netflix/conductor/dao/postgres/PostgresMetadataDAO.java 11 80.0%
Totals Coverage Status
Change from base Build 4399: -0.09%
Covered Lines: 12515
Relevant Lines: 18093

💛 - Coveralls

@manan164
Copy link
Contributor

manan164 commented Aug 2, 2020

Thanks @alex-fu for solving this.

@techyragu
Copy link

@apanicker-nflx Has the above been merged to main branch too ? How to figure out if this has been merged to main branch?

@apanicker-nflx
Copy link
Collaborator

@techyragu yes, this change is available in the main branch too. The main branch was cut out of master branch at some point in December of last year, and all changes have been actively ported over since.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants