Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

[UI] Optimize display format of task logs #2787

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

hankquan
Copy link
Contributor

@hankquan hankquan commented Feb 27, 2022

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

Changes:

  1. Now, timestamp column uses 50% width in task log which wastes lots of area. In this chage, log time column is fixed to 180px which is enough to show timestamp.
  2. Time entry doesn't support word wrap, for a log message contains \n, the UI table can't display it in a new line. This change also add css styles to support it.

Alternatives considered

Maybe there are other ways to approach the same target, this change can also be abandoned if there are better ways. But please consider the idea of this display improvement.

@hankquan
Copy link
Contributor Author

Current task logs:
tasklog_old1
tasklog_old2

After this change:
tasklog_new1
tasklog_new2

@aravindanr aravindanr requested a review from peterlau February 28, 2022 22:59
@peterlau peterlau merged commit 2369513 into Netflix:main Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants