This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
TaskMapperContext refactoring. #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. taskToSchedule -> workflowTask 2. workflowInstance -> workflowModel 3. Removed unused WorkflowDefinition. 4. Changed bean name from taskProcessorsMap to taskMappersByTaskType.
aravindanr
force-pushed
the
taskmapper_refactoring
branch
from
4a6eec9 to
4f56879
Compare
|
@apanicker-nflx @jxu-nflx PR will be easier to review if each commit is reviewed separately. |
…ing to its status.
aravindanr
force-pushed
the
taskmapper_refactoring
branch
from
4d1ba29 to
6e6195b
Compare
apanicker-nflx
approved these changes
Mar 28, 2022
jxu-nflx
reviewed
Mar 29, 2022
| long epochMillis = System.currentTimeMillis(); | ||
| forkTask.setStartTime(epochMillis); | ||
| forkTask.setEndTime(epochMillis); | ||
| forkTask.setEndTime(epochMillis); |
jxu-nflx
reviewed
Mar 29, 2022
| dynamicTask.setTaskDefName(taskToSchedule.getName()); | ||
| dynamicTask.setCorrelationId(workflowInstance.getCorrelationId()); | ||
| dynamicTask.setScheduledTime(System.currentTimeMillis()); | ||
| dynamicTask.setTaskType(workflowTask.getType()); |
There was a problem hiding this comment.
dynamicTask.setTaskType(workflowTask.getType()); this line can be removed
jxu-nflx
reviewed
Mar 29, 2022
| * @param joinWorkflowTask: A instance of {@link WorkflowTask} which is of type {@link | ||
| * TaskType#JOIN} | ||
| * @param joinInput: The input which is set in the {@link TaskModel#setInputData(Map)} | ||
| * @return a new instance of {@link TaskModel} representing a {@link TaskType#JOIN} | ||
| */ | ||
| @VisibleForTesting | ||
| TaskModel createJoinTask( | ||
| WorkflowModel workflowInstance, | ||
| WorkflowModel workflowModel, | ||
| WorkflowTask joinWorkflowTask, | ||
| HashMap<String, Object> joinInput) { | ||
| TaskModel joinTask = new TaskModel(); |
There was a problem hiding this comment.
Should this be replaced with createTaskModel as well?
There was a problem hiding this comment.
This can't be, because the joinWorkflowTask is not part of the TaskMapperContext. See https://github.com/Netflix/conductor/blob/main/core/src/main/java/com/netflix/conductor/core/execution/mapper/ForkJoinDynamicTaskMapper.java#L212-L225
jxu-nflx
approved these changes
Mar 29, 2022
# Conflicts: # core/src/main/java/com/netflix/conductor/core/execution/mapper/SubWorkflowTaskMapper.java
aravindanr
force-pushed
the
taskmapper_refactoring
branch
from
52b03c8 to
0b6750f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
taskToSchedule->workflowTask.workflowInstance->workflowModel.workflowDefinition.taskProcessorsMaptotaskMappersByTaskType.WorkflowTaskandWorkflowModel.FORK_JOIN_DYNAMICnow setsstartTime.TaskMapperimplementations set the time fields inTaskModelcorresponding to its status.startandexecutemethods fromWait.