This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Optional subworkflow task #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ITH_ERRORS with the same status (i.e. COMPLETED_WITH_ERRORS)
…e parent workflow status will not update even if the subworkflow is retried/rerun/restarted
aravindanr
approved these changes
May 16, 2022
|
|
||
| ### Optional Sub Workflow Task | ||
| If the Sub Workflow task is defined as optional in the parent workflow task definition, the parent workflow task will not be retried if sub-workflow is terminated or failed. | ||
| In additional, even if the sub-workflow is retried/rerun/restarted after reaching to a terminal status, the parent workflow task status will remain as it is. |
| @@ -653,6 +653,13 @@ private void updateAndPushParents(WorkflowModel workflow, String operation) { | |||
| // update parent's sub workflow task | |||
| TaskModel subWorkflowTask = | |||
| executionDAOFacade.getTaskModel(workflow.getParentWorkflowTaskId()); | |||
| if (subWorkflowTask.getWorkflowTask() != null | |||
There was a problem hiding this comment.
The null check is redundant, In a TaskModel instance, WorkflowTask should always be present.
apanicker-nflx
approved these changes
May 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered