This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Fix DO_WHILE loops containing a SWITCH task #3174
Merged
+487
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Cypress test cases - Keep only one 'cosmetic' arc between DO_WHILE and DO_WHILE_END bars. The arc is flows top-to-bottom to maintain the acyclic nature of DAG, arrow being rendered in reverse by CSS only.
|
@pablocubico Note that the cypress test cases can be run interactively with the command |
|
@peterlau Thanks! will keep that in mind |
pmchung
pushed a commit
to routific/conductor
that referenced
this pull request
Sep 6, 2023
Fix DO_WHILE loops containing a SWITCH task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Alternatives considered
Incorporates PR and contribution by @pablocubico #3158