This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Refactor bulk updateWorkflowDefs API. Please note that previously the API fails on the first error, but now it continues to process every item in the list and return a list of success and failures #3242
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravindanr
approved these changes
Sep 19, 2022
core/src/main/java/com/netflix/conductor/service/MetadataServiceImpl.java
Outdated
Show resolved
Hide resolved
| @@ -119,11 +122,22 @@ public void updateWorkflowDef(WorkflowDef workflowDef) { | |||
| /** | |||
| * @param workflowDefList Workflow definitions to be updated. | |||
| */ | |||
| public void updateWorkflowDef(List<WorkflowDef> workflowDefList) { | |||
| public BulkResponse updateWorkflowDef(List<WorkflowDef> workflowDefList) { | |||
There was a problem hiding this comment.
Doesnt this change the behavior of the API? Previously, the API fails on the first error, but now it continues to process every item in the list. I suggest, we call this out in the release notes.
There was a problem hiding this comment.
yes, it does change the API behavior. I'll make sure we have that documented in the release note
jxu-nflx
force-pushed
the
chore/refactor
branch
from
fd2795c to
8fd8b2d
Compare
apanicker-nflx
approved these changes
Sep 19, 2022
jxu-nflx
changed the title
pmchung
pushed a commit
to routific/conductor
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e results
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Code refactor of the bulk updateWorkflowDefs API
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered