This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
removing event handlers once it is removed from storage. #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravindanr
approved these changes
Sep 27, 2022
apanicker-nflx
approved these changes
Sep 27, 2022
pmchung
pushed a commit
to routific/conductor
that referenced
this pull request
Sep 6, 2023
* removing event handlers once it is removed from storage. * codestyle * stop listening not active event handlers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Partially addresses: #3257
When conductor event handlers are removed using
DELETE /api/event/<name>it is just removed from storage and observable queues are never stopped.This fix stops event handlers and deletes them from in-memory the same way as they are added and started
One way to handle changes is set event handler
active=falsewith other changes, wait 60 sec once it is stopped and then setactive=trueagain.