This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Add spring support for annotated workers #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mytang0
reviewed
Feb 17, 2023
| @@ -0,0 +1,48 @@ | |||
| /* | |||
| * Copyright 2020 Netflix, Inc. | |||
There was a problem hiding this comment.
Fixed. Thanks for pointing out.
| @ConditionalOnMissingBean | ||
| @Bean | ||
| public AnnotatedWorkerExecutor annotatedWorkerExecutor(ClientProperties clientProperties) { | ||
|
|
There was a problem hiding this comment.
Do we need to make sure that this bean is created later than other beans to avoid omissions?
There was a problem hiding this comment.
Addressed this by doing the initialization using context initialization event.
1. Add annotation support for pollingInterval 2. Allow configuration using spring 3. Tests
v1r3n
force-pushed
the
sdk_worker_enhancements
branch
from
bd26688 to
5bdb4ac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
@Componentto the classes that has worker methods and they will get auto-initialized.callbackAfterfor long running tasksTaskContextallows getting access to the task and task result for inspecting task level informationDescribe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered