Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

Lazy evaluate workflow only in case of task is successful. #3655

Merged
merged 3 commits into from
Jun 21, 2023
+9 −2
Merged

Lazy evaluate workflow only in case of task is successful. #3655

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48e23ef
Lazy evaluate workflow only in case of task is successful.
manan164 Jun 15, 2023
73e3e66
spotless
manan164 Jun 15, 2023
15b2298
unit test
manan164 Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
spotless
@manan164
manan164 committed Jun 15, 2023
commit 73e3e66fcb5a2ce57674b63448585c8fbf347169
6 changes: 4 additions & 2 deletions core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java
View file
Original file line number Diff line number Diff line change
@@ -925,10 +925,12 @@ boolean isLazyEvaluateWorkflow(WorkflowDef workflowDef, TaskModel task) {
.collect(Collectors.toList());

if (forkTasks.stream().anyMatch(fork -> fork.has(taskRefName))) {
return joinTasks.stream().anyMatch(join -> join.getJoinOn().contains(taskRefName)) && task.getStatus().isSuccessful();
return joinTasks.stream().anyMatch(join -> join.getJoinOn().contains(taskRefName))
&& task.getStatus().isSuccessful();
}

return workflowTasks.stream().noneMatch(t -> t.getTaskReferenceName().equals(taskRefName)) && task.getStatus().isSuccessful();
return workflowTasks.stream().noneMatch(t -> t.getTaskReferenceName().equals(taskRefName))
&& task.getStatus().isSuccessful();
}

public TaskModel getTask(String taskId) {