-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add support for object input default values and add support for default inputs to kotlin2 #680
Conversation
c521a26
to
523569e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Would you also be able to fix the Java code path as well as part of this PR? If not, we can open a new issue for it.
Sure, I'll take a stab at it shortly. |
While peeking at java code path I've found a bug in kotlin path. When using typeMapping with Regarding Java path it will be slightly more difficult. In Kotlin path I used named parameters. In Java I see 4 paths:
|
I've implemented option 2. Lmk what do you think 🙏 |
I realised that kotlin2 did not support default values at all. Now experience with default values should be the same across codegen configurations. |
9288bff
to
9aa4b1f
Compare
@mbossenbroek This PR contains kotlin2 changes - added support for default values in input types 😉 If it make sense to you I can split changes into 2 PRs; one for object defaults, one adding kotlin2 default values |
Looks good to me! 👍 I'll let @srinivasankavitha merge it cause there are other changes in there too |
@srinivasankavitha Are you waiting for any action from my side or is it ready to go? I'm not a huge fan of stale PRs hanging out in void 😅 |
Sorry for the delay, and thanks for bringing this back to my attention. Just merged the PR and will go out in next week's release. |
closes #297