Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create singleton empty CodeGenResult instance #725

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

kilink
Copy link
Member

@kilink kilink commented Jul 22, 2024

Create a singleton empty CodeGenResult instance, CodeGenResult.EMPTY, and update the merge method to more intelligently handle merging to avoid excessive copying.

Create a singleton empty CodeGenResult instance, CodeGenResult.EMPTY, and update the merge
method to more intelligently handle merging to avoid excessive copying.
Copy link
Contributor

@Emily Emily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should avoid a lot of object allocation :)

@kilink kilink merged commit 76679a6 into master Jul 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants