Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [k2] add support for data types inherited from extended interface #741

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

Lavmee
Copy link
Contributor

@Lavmee Lavmee commented Sep 6, 2024

Closes: #740

@Lavmee Lavmee marked this pull request as draft September 6, 2024 09:33
… rollback extensionTypes definition (because of graphql specification)

graphql specification (interface extensions): https://spec.graphql.org/October2021/#sel-GAHbpBBBBKBUytV
@Lavmee Lavmee marked this pull request as ready for review September 6, 2024 09:46
@Lavmee
Copy link
Contributor Author

Lavmee commented Sep 9, 2024

Hey @srinivasankavitha, can you take a look at this pull request?

@Lavmee Lavmee changed the title feat: add support for data types inherited from extended interface feat: [k2] add support for data types inherited from extended interface Sep 13, 2024
Copy link
Contributor

@dwilkolek dwilkolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! cc: @mbossenbroek 😉

@mbossenbroek
Copy link
Contributor

This lgtm - @srinivasankavitha I'm happy to merge, but github says it needs a maintainer to do it

@srinivasankavitha srinivasankavitha merged commit 78f6c92 into Netflix:master Oct 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K2 | Add support for data types inherited from extended interface
4 participants