Update to jdk17 and DGS to latest 9.x. #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilink
reviewed
Oct 17, 2024
...s-codegen-shared-core/src/main/kotlin/com/netflix/graphql/dgs/client/codegen/GraphQLQuery.kt
Outdated
Show resolved
Hide resolved
paulbakker
approved these changes
Oct 18, 2024
paulbakker
requested review from
iparadiso,
jjacobs44,
asibross,
iuliiasobolevska and
kzwang
| repositories: | ||
| - "git@github.com:Netflix/dgs-examples-java-2.7.git" | ||
| - "git@github.com:Netflix/dgs-examples-kotlin-2.7.git" | ||
| #repositories: |
There was a problem hiding this comment.
are these intentionally commented out? the same for clone_repos?
There was a problem hiding this comment.
Yes, intentional, will delete.
iuliiasobolevska
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the plugin to JDK 17 and latest DGS, which brings in graphql-java 22. Users are increasingly running into issues because of incompatibilities.(#561)
This is a breaking change and will affect DGSs that are not on SBN 3.x + JDK 17. These apps will need to pin back to the last release prior to this change.