-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Spring Boot 3.3 #1920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the main change ends up being the async preparsed document provider? I think this lgtm assuming the test is fixed
For release notes:
|
@@ -178,6 +179,7 @@ class ErrorsTest { | |||
} | |||
|
|||
@Test | |||
@Disabled("Broken by Jackson 2.17 https://github.com/FasterXML/jackson-databind/issues/4508") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a workaround in that linked issue that we could apply instead:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kilink From what I understand from the issue is that the workaround is for the Jackson folks to do, it's not something we can do as a user of Jackson.
Pull Request type
Changes in this PR
Upgrade to Spring Boot 3.3, which comes with graphql-java 22 and federation 5.0.0.