Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping for dgs graphql path property to spring-graphql integration #1933

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

kailyak
Copy link
Contributor

@kailyak kailyak commented Jun 5, 2024

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

Spring graphql has a config property for graphql path, this change adds a mapping for the dgs-frameworks's graphql path property in the dgs spring-graphql integration.

Issue # 1931

Testing Done

  • Tested manually by adding dgs.graphql.path: /dummy/graphql to graphql-dgs-spring-graphql-example-java example app's applicaltion.yml and testing via curl commands to default path /graphql and custom path /dummy/graphql.
  • Added code tests.

Copy link
Collaborator

@paulbakker paulbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kailyak kailyak merged commit df5df01 into master Jun 6, 2024
3 checks passed
@kailyak kailyak deleted the map-graphql-path-dgs-property branch June 6, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants