Skip to content

Commit

Permalink
Use the correct filter (#3662)
Browse files Browse the repository at this point in the history
* Use the correct filter

* Ruff
  • Loading branch information
kevgliss authored Aug 3, 2023
1 parent ae4f708 commit 11825f5
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/dispatch/signal/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
from dispatch.tag import service as tag_service
from dispatch.workflow import service as workflow_service
from dispatch.entity.models import Entity
from dispatch.models import PrimaryKey

from .models import (
Signal,
Expand Down Expand Up @@ -208,11 +207,12 @@ def get_signal_instance(
)


def get(*, db_session: Session, signal_id: Union[PrimaryKey, str]) -> Optional[Signal]:
def get(*, db_session: Session, signal_id: Union[str, int]) -> Optional[Signal]:
"""Gets a signal by id or external_id."""
signal = db_session.query(Signal).filter(Signal.id == signal_id).one_or_none()
if not signal:
signal = db_session.query(Signal).filter(Signal.external_id == str(signal_id)).one_or_none()
if isinstance(signal_id, int):
signal = db_session.query(Signal).filter(Signal.id == signal_id).one_or_none()
else:
signal = db_session.query(Signal).filter(Signal.external_id == signal_id).one_or_none()
return signal


Expand Down

0 comments on commit 11825f5

Please sign in to comment.