bugfix: no __contains__ on StrEnum until 3.12 (#4933)

Netflix · Jul 8, 2024 · b00b5b2 · b00b5b2
1 parent cb60cd4
commit b00b5b2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/dispatch/enums.py b/src/dispatch/enums.py
@@ -14,7 +14,12 @@ class Visibility(DispatchEnum):
             RESTRICTED = "Restricted"
 
         assert str(Visibility.OPEN) == "Open"
-        assert "Open" in Visibility
+
+    Note:
+        In `3.12` we will get `__contains__` functionality:
+
+        DeprecationWarning: in 3.12 __contains__ will no longer raise TypeError, but will return True or
+        False depending on whether the value is a member or the value of a member
     """
 
     pass  # No additional implementation needed

diff --git a/src/dispatch/plugins/dispatch_slack/service.py b/src/dispatch/plugins/dispatch_slack/service.py
@@ -104,7 +104,7 @@ def should_retry(exception: Exception) -> bool:
     match exception:
         case SlackApiError():
             # Don't retry for exceptions we have defined.
-            return exception.response["error"] not in SlackAPIErrorCode
+            return exception.response["error"] not in SlackAPIErrorCode.__members__.values()
         case TimeoutError() | Timeout():
             # Always retry on timeout errors
             return True