Refactor E2E tests to use Page Object Model (POM), fixtures, and add additional tests #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssheldon
added
enhancement
wssheldon
commented
Feb 6, 2023
| @@ -39,6 +39,7 @@ | |||
| :sort-by.sync="sortBy" | |||
| :sort-desc.sync="descending" | |||
| :loading="loading" | |||
| data-testid="incident-data-table" | |||
There was a problem hiding this comment.
We may want to consider a single SOT for these data-testid strings as an Enum that we can use here and in tests Pages
wssheldon
commented
Feb 6, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| async function register(authPage: AuthPage): Promise<void> { | ||
| let email = generateRandomString() + "@example.com" | ||
| let password = generateRandomString() |
Check failure
Code scanning / CodeQL
Insecure randomness
wssheldon
commented
Feb 6, 2023
| @@ -0,0 +1,9 @@ | |||
| export const orgSlug = "default" | |||
|
|
|||
| export enum Routes { | |||
There was a problem hiding this comment.
Would be nice if we could import these directly from the Vue router. I was unable to import the routes because of an issue with this line and others upon import (can't use this outside module, or similar error):
const authProviderSlug =
import.meta.env.VITE_DISPATCH_AUTHENTICATION_PROVIDER_SLUG || "dispatch-auth-provider-basic"
wssheldon
commented
Feb 6, 2023
| readonly EditRunWorkflow: Locator | ||
| readonly EditDelete: Locator | ||
|
|
||
| constructor(page: Page, incident: string = `dispatch-${orgSlug}-${orgSlug}-2`) { |
There was a problem hiding this comment.
The default incident here is a bit fragile to it being present in the table, there's probably a better way.
wssheldon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://playwright.dev/docs/pom
https://playwright.dev/docs/test-fixtures