Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added visibility to welcome message #3019

Merged
merged 11 commits into from
Mar 3, 2023
Merged

Added visibility to welcome message #3019

merged 11 commits into from
Mar 3, 2023

Conversation

jneelamekam
Copy link
Contributor

No description provided.

@jneelamekam jneelamekam added the enhancement New feature or request label Feb 23, 2023
Copy link
Contributor

@wssheldon wssheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of typo/style suggestions.

src/dispatch/incident/messaging.py Outdated Show resolved Hide resolved
src/dispatch/messaging/strings.py Outdated Show resolved Hide resolved
src/dispatch/messaging/strings.py Outdated Show resolved Hide resolved
src/dispatch/messaging/strings.py Show resolved Hide resolved
jneelamekam and others added 4 commits February 22, 2023 20:15
Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
src/dispatch/messaging/strings.py Outdated Show resolved Hide resolved
src/dispatch/incident/messaging.py Outdated Show resolved Hide resolved
@jneelamekam jneelamekam merged commit 1f5eb55 into master Mar 3, 2023
@jneelamekam jneelamekam deleted the SIRT-213 branch March 3, 2023 02:31
rutvijmehta-harness pushed a commit to rutvijmehta-harness/dispatch that referenced this pull request Mar 17, 2023
* Added visibility to welcome message

* Update src/dispatch/incident/messaging.py

Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>

* Update src/dispatch/messaging/strings.py

Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>

* Update src/dispatch/messaging/strings.py

Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>

* Update src/dispatch/messaging/strings.py

Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>

* Update src/dispatch/messaging/strings.py

Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>

* updated visibility

---------

Co-authored-by: Janani Neelamekam <jneelamekam@netflix.com>
Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
rutvijmehta-harness added a commit to rutvijmehta-harness/dispatch that referenced this pull request Mar 17, 2023
* Added visibility to welcome message

* Update src/dispatch/incident/messaging.py



* Update src/dispatch/messaging/strings.py



* Update src/dispatch/messaging/strings.py



* Update src/dispatch/messaging/strings.py



* Update src/dispatch/messaging/strings.py



* updated visibility

---------

Co-authored-by: jneelamekam <67976897+jneelamekam@users.noreply.github.com>
Co-authored-by: Janani Neelamekam <jneelamekam@netflix.com>
Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants