-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added visibility to welcome message #3019
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssheldon
reviewed
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple of typo/style suggestions.
Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
wssheldon
approved these changes
Feb 23, 2023
mvilanova
reviewed
Feb 28, 2023
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
* Added visibility to welcome message * Update src/dispatch/incident/messaging.py Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com> * Update src/dispatch/messaging/strings.py Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com> * Update src/dispatch/messaging/strings.py Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com> * Update src/dispatch/messaging/strings.py Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com> * Update src/dispatch/messaging/strings.py Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com> * updated visibility --------- Co-authored-by: Janani Neelamekam <jneelamekam@netflix.com> Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com> Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
rutvijmehta-harness
added a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
* Added visibility to welcome message * Update src/dispatch/incident/messaging.py * Update src/dispatch/messaging/strings.py * Update src/dispatch/messaging/strings.py * Update src/dispatch/messaging/strings.py * Update src/dispatch/messaging/strings.py * updated visibility --------- Co-authored-by: jneelamekam <67976897+jneelamekam@users.noreply.github.com> Co-authored-by: Janani Neelamekam <jneelamekam@netflix.com> Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com> Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.