Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snooze button to signal instance message in Slack plugin and add Case/Signal subject enum #3073

Merged
merged 11 commits into from
Mar 8, 2023

Conversation

wssheldon
Copy link
Contributor

@wssheldon wssheldon commented Mar 7, 2023

Screenshot 2023-03-07 at 12 04 40 PM

@wssheldon wssheldon added the enhancement New feature or request label Mar 7, 2023
@wssheldon wssheldon marked this pull request as ready for review March 7, 2023 20:04
@kevgliss
Copy link
Contributor

kevgliss commented Mar 7, 2023

For the layout, I wonder if we should have an actions pull down? e.g. it would have "view raw" and "snooze" as options. I would like to be cautious of the amount of vertical space we take up.

@wssheldon
Copy link
Contributor Author

@kevgliss 89f3d38

@wssheldon wssheldon merged commit 6a6f79b into master Mar 8, 2023
@wssheldon wssheldon deleted the enhancement/snooze-button branch March 8, 2023 00:11
rutvijmehta-harness pushed a commit to rutvijmehta-harness/dispatch that referenced this pull request Mar 17, 2023
…Case/Signal subject enum (Netflix#3073)

* Add buttom template and add subject enum

* Adds signal retrieval for instance case

* use subject var

* Switch snooze to signal notification enum

* Account for not being inside a modal

* unused import

* rename case snooze enum symbol to signal snooze

* fix pytest for signalUpdate
rutvijmehta-harness added a commit to rutvijmehta-harness/dispatch that referenced this pull request Mar 17, 2023
…Case/Signal subject enum (Netflix#3073) (#58)

* Add buttom template and add subject enum

* Adds signal retrieval for instance case

* use subject var

* Switch snooze to signal notification enum

* Account for not being inside a modal

* unused import

* rename case snooze enum symbol to signal snooze

* fix pytest for signalUpdate

Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants