Changes signals ingestion from opt in to opt out approach #4396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvilanova
changed the title
|
It looks good. Have you tested ingesting a signal instance w/ and w/o a definition locally? |
Not yet. Dealing with an issue with the signal definition create form. |
mvilanova
commented
Feb 15, 2024
mvilanova
commented
Feb 15, 2024
|
@whitdog47 looks like your changes here broke the signal definition create form. I added support for checking via project name to fix it. |
mvilanova
commented
Feb 15, 2024
Tested the code with a signal with external id/variant and one without it. |
wssheldon
reviewed
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the signal ingestion approach from opt-in to opt-out for signals submitted via API or consumed through a signal consumer plugin.