Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates classic cost model to append new response costs instead of overwriting them. #4552

Merged
merged 5 commits into from
Apr 1, 2024

Conversation

metroid-samus
Copy link
Contributor

@metroid-samus metroid-samus commented Mar 27, 2024

This PR adds the following changes:

  • Adds the incident review cost to the incident only when the incident review document is created.
  • Updates the classic cost model to add new incident response costs since the last update instead of recalculating the entire cost.
  • Refactors the Incident Cost service.
  • Increases code coverage of the Incident Cost service to 90%.
  • Improves documentation.

… them. Improves incident_cost_service code coverage.
@metroid-samus metroid-samus self-assigned this Mar 27, 2024
@metroid-samus metroid-samus added the enhancement New feature or request label Mar 27, 2024
@metroid-samus metroid-samus marked this pull request as ready for review March 27, 2024 01:07
@metroid-samus metroid-samus requested a review from mvilanova March 27, 2024 20:04
@metroid-samus metroid-samus merged commit 37c50fc into master Apr 1, 2024
8 checks passed
@metroid-samus metroid-samus deleted the enhancement/update_incident_cost branch April 1, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants