Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slack): don't use snooze ack, refactor engagement ack to generalized mfa ack #5291

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix(slack): don't use snooze ack, refactor engagement ack to generalized mfa ack #5291

merged 1 commit into from
Oct 4, 2024

Conversation

wssheldon
Copy link
Contributor

@wssheldon wssheldon commented Oct 4, 2024 •
edited
Loading

We called ack_engagement_submission_event later on, but since we called ack_snooze_submission_event it will update the modal first and not supply the confirmation link.

Before

Screenshot 2024-10-04 at 1 39 37 PM

After

Screenshot 2024-10-04 at 1 41 03 PM

Tested end-to-end locally.

@wssheldon wssheldon added the bug Something isn't working label Oct 4, 2024
@wssheldon wssheldon self-assigned this Oct 4, 2024
@wssheldon wssheldon merged commit 77eb5e5 into master Oct 4, 2024
10 checks passed
@wssheldon wssheldon deleted the fix/use-mfa-required-ack-on-snooze branch October 4, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvilanova mvilanova mvilanova approved these changes

Assignees

@wssheldon wssheldon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wssheldon @mvilanova