Improves warning text when there are no users to engage #5314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve logging messages and streamline test execution. The most important changes involve updating log messages in the
engage_signal_identityfunction and modifying the test entry in the pre-commit configuration.Logging Improvements:
src/dispatch/signal/flows.py: Updated log messages in theengage_signal_identityfunction to include the signal name along with its ID for better clarity. [1] [2]Test Configuration:
.pre-commit-config.yaml: Modified the test entry to specify thetests/directory when runningpytest.