Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add dedicated status tab for can report in incident edit sheet #5459

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

wssheldon
Copy link
Contributor

@wssheldon wssheldon commented Nov 13, 2024

Here nor there on the name or position of the tab. We could call it CAN, but I doubt that's widely understood.

Screenshot 2024-11-12 at 4 42 51 PM

 ✓ src/tests/TimelineReportTab.spec.js (7)
   ✓ mounts correctly and displays tactical reports
   ✓ filters out non-tactical report events
   ✓ displays event details correctly
   ✓ sorts events chronologically
   ✓ displays UTC time notice
   ✓ handles empty events array
   ✓ displays correct icon for tactical reports

 Test Files  1 passed (1)
      Tests  7 passed (7)
   Start at  16:57:50
   Duration  471ms

@wssheldon wssheldon added the enhancement New feature or request label Nov 13, 2024
@wssheldon wssheldon self-assigned this Nov 13, 2024
@mvilanova
Copy link
Contributor

I'd call it Reports, as that's what they're.

@wssheldon wssheldon merged commit 1792378 into master Nov 13, 2024
9 checks passed
@wssheldon wssheldon deleted the feat/status-tab branch November 13, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants