Open
Conversation
Contributor
|
@tiodollar this seems to fail the test cases. Any idea why? What is the case that this is needed? |
Contributor
Author
|
@ipapapa With the merge, All checks have passed. |
ipapapa
reviewed
Jun 30, 2017
| unsuppliedPort = port; | ||
| } | ||
|
|
||
| public AbstractTokenMapSupplier(int port,String localZone,String localDatacenter) { |
Contributor
There was a problem hiding this comment.
Why do we need this extra constructor? I do not see it being used in this PR.
ipapapa
suggested changes
Jun 30, 2017
Contributor
ipapapa
left a comment
ipapapa
left a comment
There was a problem hiding this comment.
It would be nice to add a few test cases to make sure that we have proper coverage as this is a new feature. I believe we have the HTTP based token map supplier tests that you can leverage. An example would be to create an exemplary JSON response from Dynomite and use that as the basis for testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support to dynomite REST API to search the cluester tokens https://github.com/Netflix/dynomite/wiki/REST.