Added workaround for RSJS Webpack bug (specified in file) #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePrimeagen
added a commit
that referenced
this pull request
Jul 25, 2015
Added workaround for RSJS Webpack bug (specified in file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RxJS bug is here: Reactive-Extensions/RxJS#832
The Details/Repo are here: https://github.com/sdesai/rxjs-webpack-test
It addresses part of issue: #338
This will let folks build 'falcor' with webpack and have the bundle work (it'll send out requests).
Still need to provide the right advice for people who include 'falcor' as a dependency and want to build with WebPack, until the RxJS bug is fixed, because defining a webpack.config.js entry for them, along the same lines, would require them to reach into
node_modules/falcor/node_modules/rx/dist/rxwhich does work, but is a little ugly.