Regression: Date/Time is no longer serialized as ISO8601

I upgraded from 1.0.17 to 1.1.1 and somewhere (likely #58) the way date/timestamps are serialized regressed from being ISO8601 strings to simple time strings. Luckily my serializer specs caught it.

-      "created_at": "2018-03-22T09:45:00.246Z",
-      "updated_at": "2018-03-22T09:45:00.246Z",
+      "created_at": "2018-03-22 09:45:00 UTC"
+      "updated_at": "2018-03-22 09:45:00 UTC",

[bf4]

The change

-        MultiJson.dump(payload) if payload.present?
+        FastJsonapi::MultiToJson.to_json(payload) if payload.present?

should have used the same oj configs as multijson, as well as for the other json gems.

I'm guessing you don't have Oj installed and got bit by the bug fixed by #130

Let me know if I can help you debug

[shishirmk]

@bf4 i would like to understand why that fix would change the date format. Based on my conversation with @martndemus he never had oj and he was always using default json engine

[bf4]

@shishirmk IIRC, the bug fixed by #130 only affected installs lacking Oj. Perhaps I'm wrong about that. In any case it should be pretty easy to debug what's going on by

FastJsonapi::MultiToJson.to_json_method # => what's the output of this?

# and to remove any doubt
$VERBOSE = true
FastJsonapi::MultiToJson.logger(STDOUT)
FastJsonapi::MultiToJson.reset_to_json!
FastJsonapi::MultiToJson.to_json(payload)

Another possibility is that it's using %(::ActiveSupport::JSON.encode(object)) which wasn't part of the MultiJSON cascade.

It would be easier to reproduce and debug in discussion with @martndemus which is why I offered. There's some info that would be helpful just as other gems installed and a unix time that could be used for comparison.

Adding OJ as dep did fix it. So I guess that's what's happening. Would adding OJ by default make sense to keep backwards compat?

[bf4]

@martndemus OJ depends on CRuby. did you try debugging the code as I suggested? I think if you were to bundle open fast_jsonapi and comment out the active support line, you'd get your original behavior.

[neongrau]

Having the same issue. But added to that when i installed OJ, serialization times doubled.
Which was due to OJ not being set for rails_optimize. But then can't activate Rails optimizations as OJ (3.5) segfaults with that when encountering Time objects before 1970. So i have either wrongly formatted date strings in the JSON output, horribly slow serialization or a segfaulting ruby.

[bf4]

Just putting it out there again, I'll pair with anyone who can reproduce this. http://www.benjaminfleischer.com/pair/ or if you can make a test repo I'll look at it.

[shishirmk]

@neongrau could you please get in touch with @bf4?

[shishirmk]

Closing as there is no response and we have released a new version of the gem v1.2

[dominiceden]

I had this issue too with version 1.1.1. Solved by installing the oj gem.

[bf4]

@dominiceden would you be interested in trying the debug I mentioned in #135 (comment) or pairing with me to see what the problem was?

[nicolasrouanne]

@bf4 I have the 1.2 version and the same issue. Installing oj solved it as well. I would be glad to help you debug if need be.