Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor initialization of persistence and metrics classes to be transparent to clients #25

Closed
sriramkrishnan opened this issue Sep 6, 2013 · 1 comment
Closed

Refactor initialization of persistence and metrics classes to be transparent to clients #25

sriramkrishnan opened this issue Sep 6, 2013 · 1 comment
Assignees
@sriramkrishnan
Labels
feature

Comments

@sriramkrishnan
Copy link
Contributor

Currently the PersistenceManager is expected to be initialized using the init() method. But the constructor also calls the init() method. Hence, this is redundant, and should be cleaned up.

Similarly, the classes in the com.netflix.genie.server.metrics must be similarly cleaned up.
@ghost ghost assigned sriramkrishnan Sep 6, 2013
sriramkrishnan added a commit that referenced this issue Sep 6, 2013
@sriramkrishnan
Cleanup for Issue #25
b51efce
sriramkrishnan added a commit that referenced this issue Sep 6, 2013
@sriramkrishnan
Adding Issue #25
6123c7d
sriramkrishnan added a commit that referenced this issue Sep 7, 2013
@sriramkrishnan
Issue #25: cleaning up test case
fe23479
sriramkrishnan added a commit that referenced this issue Sep 7, 2013
@sriramkrishnan
More test cleanup for issue #25
51a3f7c
sriramkrishnan added a commit that referenced this issue Sep 7, 2013
@sriramkrishnan
Issue #25: now verifying entity manager factory prior to each call
37ed40a
@sriramkrishnan
Copy link
Contributor Author

Check-in fixes.

sriramkrishnan added a commit that referenced this issue Sep 18, 2013
@sriramkrishnan
Issue #25: first pass at support for attachments
b49a44d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sriramkrishnan sriramkrishnan

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sriramkrishnan