Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover IllegalAttachmentFileNameException in GenieExceptionMapperTest #1213

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

bhou2
Copy link
Contributor

@bhou2 bhou2 commented Apr 30, 2024

Cover IllegalAttachmentFileNameException in GenieExceptionMapperTest

@bhou2 bhou2 requested a review from zdong2 April 30, 2024 00:18
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (67a44e5) to head (c0421f4).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1213      +/-   ##
============================================
+ Coverage     90.81%   90.83%   +0.02%     
- Complexity     3812     3815       +3     
============================================
  Files           468      468              
  Lines         14988    14988              
  Branches       1073     1073              
============================================
+ Hits          13611    13615       +4     
+ Misses          911      909       -2     
+ Partials        466      464       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zdong2 zdong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhou2 bhou2 merged commit a385b55 into master Apr 30, 2024
4 checks passed
@bhou2 bhou2 deleted the dev-snapshot branch April 30, 2024 19:09
natedanner pushed a commit to natedanner/Netflix__genie that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants