Skip to content

Commit

Permalink
remove rxnetty metrics module (#270)
Browse files Browse the repository at this point in the history
We typically use the http request level metrics to
understand what the clients are doing. The lower level
rxnetty metrics aren't used much and don't follow
the recommended conventions so we would prefer not
to publish them for our apps by default.

An app owner can explicitly enable if they are still
desirable in certain use-cases.
  • Loading branch information
brharrington authored Aug 31, 2016
1 parent 64a5d6c commit 9d1172e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ lazy val `iep-module-rxnetty` = project
Dependencies.guiceCore,
Dependencies.rxnettyCore,
Dependencies.rxnettyCtxts,
Dependencies.rxnettySpectator,
Dependencies.slf4jApi
))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
import com.netflix.iep.http.EurekaServerRegistry;
import com.netflix.iep.http.RxHttp;
import com.netflix.iep.http.ServerRegistry;
import io.reactivex.netty.RxNetty;
import io.reactivex.netty.spectator.SpectatorEventsListenerFactory;

import javax.inject.Singleton;

Expand Down Expand Up @@ -58,7 +56,6 @@ ServerRegistry getServerRegistry() {
}

@Override protected void configure() {
RxNetty.useMetricListenersFactory(new SpectatorEventsListenerFactory());
}

@Provides
Expand Down

0 comments on commit 9d1172e

Please sign in to comment.