update to sbt 1.0.0 #326
Merged
update to sbt 1.0.0 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brharrington
force-pushed
the
sbt-1.0.0
branch
from
054fbc5 to
9eb86b6
Compare
Mostly went well, two primary issues found: 1. It seems to leave the terminal in a bad state. For now working around by calling `stty sane`. 2. Switch some of the non-required plugins to get versions compatible with 1.0.
brharrington
force-pushed
the
sbt-1.0.0
branch
from
9eb86b6 to
b4aa86d
Compare
Merged
brharrington
added a commit
to brharrington/iep
that referenced
this pull request
Aug 12, 2017
The tty hack added in Netflix#326 causes the exit code to be incorrect. This means the build can succeed when it shouldn't.
Merged
brharrington
added a commit
that referenced
this pull request
Aug 12, 2017
The tty hack added in #326 causes the exit code to be incorrect. This means the build can succeed when it shouldn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly went well, two primary issues found:
now working around by calling
stty sane.compatible with 1.0.
With this change we should be able to build on jdk9.