Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon discussion, though this seems simple on the surface, there are a
number of nuances that make this tricky to get right. For instance,
if a dependency has a non-daemon thread and the failure occurs in such a
way that a service such as discovery sees the app as in service, the app
could take traffic when it shouldn't.
The main change that occurred since this was put in place was a switch
to primarily use async loggers in the Insight Engineering apps. It was
previously observed that synchronous loggers would emit their logs, even
with the call to
System.exit()
. Ideally, we can restore that behaviorwith async loggers, but that may also prove to not be easy.