Remove compile dep to servlet and jetty #344
Conversation
| compile 'javax.servlet:servlet-api:2.5' | ||
| compile 'org.mortbay.jetty:jetty:6.1.26' | ||
| provided 'javax.servlet:javax.servlet-api:3.0.1' | ||
| provided 'org.mortbay.jetty:jetty:6.1.26' |
There was a problem hiding this comment.
It seems odd to make jetty provided when it is being used as an embedded server. What if the application is running outside of a servlet container or using a container other than jetty such as tomcat? Is the user expected to supply and keep track of the appropriate version of jetty?
There was a problem hiding this comment.
What was the specific issue that prompted this PR? Also, this is a very old version of jetty. Perhaps we should consider changing this to the latest version of jetty in the org.eclipse.jetty org.
There was a problem hiding this comment.
Note there were problems the last time it was updated to jetty 9 (see #220). So it would need some testing.
|
I'm just doing an upgrade of 3.0.1 for this one. We can investigate upgrading jetty later. |
|
Just FYI, since the artifact coordinate changed and the package names haven't changed, both versions of the library can get brought in and wind up loading the wrong classes. I think creating a Gradle Resolution Rule (https://github.com/nebula-plugins/gradle-resolution-rules) can help mitigate issues assuming clients use the plugin. |
|
👍 |
That caused dependency issues.