Merge pull request #4683 from jmcrawford45/SECGUIDE-4012

one canonical Flask debug config
Netflix · Nov 2, 2023 · c90d6b2 · c90d6b2
2 parents d263fe5 + e02a415
commit c90d6b2
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -3,6 +3,7 @@ Changelog
 
 Unreleased
 ~~~~~~~~~~~~~~~~~~~~
+To avoid confusion, the debug app configuration property has been replaced with the standard DEBUG flask app config.
 Added ability for new versions of LEMUR_TOKEN_SECRET via the LEMUR_TOKEN_SECRETS config option. This allows for
 migration and rotation of the secret.
 

diff --git a/docker/src/lemur.conf.py b/docker/src/lemur.conf.py
@@ -16,7 +16,7 @@
 LOG_JSON = True
 
 CORS = os.environ.get("CORS") == "True"
-debug = os.environ.get("DEBUG") == "True"
+DEBUG = os.environ.get("DEBUG") == "True"
 
 
 def get_random_secret(length):

diff --git a/lemur/manage.py b/lemur/manage.py
@@ -86,7 +86,7 @@ def cli(script_info, config):
 
 # These will need to be set to `True` if you are developing locally
 CORS = False
-debug = False
+DEBUG = False
 
 # this is the secret key used by flask session management
 SECRET_KEY = "{flask_secret_key}"

diff --git a/lemur/tests/conf.py b/lemur/tests/conf.py
@@ -20,7 +20,7 @@ def get_random_secret(length):
 
 # These will need to be set to `True` if you are developing locally
 CORS = False
-debug = False
+DEBUG = False
 
 TESTING = True