exclude python-ldap in readthedocs only #4671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcrawford45
requested review from
hosseinsh,
charhate,
jtschladen and
douglasc-nflx
as code owners
hosseinsh
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is currently broken due to #4664 . We refactored out requirements files to use -r to make global resolves easier, but this means that dependabot PRs now add python-ldap to requirements-docs.txt. Instead of focusing on removing this dep at make time, let's only remove it at the stage where it's problematic (we can't install during readthedocs build because the env doesn't support arbitrary package installs).