Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify to get local day of week #44

Closed
wants to merge 1 commit into from
Closed

Conversation

hskimsky
Copy link

@hskimsky hskimsky commented Jul 26, 2024

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew build --write-locks to refresh dependencies)
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

When running ./gradlew build, the build fails because the value of the res variable is not "Thursday".

Because my default locale is Asia/Seoul, the value of the res variable is "목요일", not "Thursday".

Therefore, I modified it to get the local day of the week.

@jun-he
Copy link
Contributor

jun-he commented Jul 26, 2024

@hskimsky will #57 resolve this problem as well?

@hskimsky
Copy link
Author

@hskimsky will #57 resolve this problem as well?

I think #57 can also solve the same problem, and I think it's an easier and better solution.

@jun-he
Copy link
Contributor

jun-he commented Jul 30, 2024

@hskimsky Thanks for the proposed solution. I will close this one as the issue has been fixed within SEL.

@jun-he jun-he closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants