Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate all com.google classes in mantis-shaded #109

Merged
merged 58 commits into from
Aug 23, 2021
Merged

Relocate all com.google classes in mantis-shaded #109

merged 58 commits into from
Aug 23, 2021

Conversation

calvin681
Copy link
Collaborator

@calvin681 calvin681 commented Aug 23, 2021 •
edited
Loading

Context

Relocate all com.google classes in mantis-shaded.

This is to fix compilation errors:

com.google.guava:guava:20.0 in configuration ':implementation' has 3 classes duplicated by io.mantisrx:mantis-shaded:1.3.36. Duplicate classes: [com/google/thirdparty/publicsuffix/PublicSuffixType, com/google/thirdparty/publicsuffix/PublicSuffixPatterns, com/google/thirdparty/publicsuffix/TrieParser]

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable
  • Added copyright headers for new files from CONTRIBUTING.md

@calvin681
Add mantis publish properties to docs
fe779dd
@calvin681
Merge remote-tracking branch 'upstream/master'
ab35293
@calvin681
Merge remote-tracking branch 'upstream/master'
75f750d
@calvin681
Merge branch 'master' of github.com:Netflix/mantis
24ac51b
@calvin681
Update MQL docs for using [*]
7811869
@calvin681
Merge remote-tracking branch 'upstream/master'
054f0b9
@calvin681
Add myself as code owners
ce18bf0
@calvin681
Merge remote-tracking branch 'upstream/master'
a35f197
@calvin681
Merge remote-tracking branch 'upstream/master'
789ab06
@calvin681
Rule base auto scale should not scale down lower than min
d4d7d4b
@calvin681
add comment
ed3c558
@calvin681
Subscribe to source job drop metrics in job master
48cf69f
@calvin681
Merge remote-tracking branch 'upstream/master'
3003e93
@calvin681
add copy right, fix tests
e489031
@calvin681
Address review comments. Add parameters to system params.
2ba5fed
@calvin681
Handle empty string for drop metric param
552c94d
@calvin681
merge upstream
07741f3
@calvin681
Merge remote-tracking branch 'upstream/master'
691d291
@calvin681
Fix bug in determining source job metric vs job metric
5fc5236
@calvin681
Merge remote-tracking branch 'upstream/master'
a5b7eae
@calvin681
Add ClutchRps auto scaler, outlier detection using sourcejob drop
ee3398a
@calvin681
clean up
0074bab
@calvin681
add copyright
8d918c7
@calvin681
fix tests
c5bf421
@calvin681
make setpoint percentile configurable
fdb8505
@calvin681
add more test on config generation
234874a
@calvin681
add test message
0b42dea
@calvin681
Merge remote-tracking branch 'upstream/master'
118eeff
@calvin681
Rope uses absolute values instead of percentage
17ec535
@calvin681
Merge remote-tracking branch 'upstream/master'
c6fdaf6
@calvin681
Merge remote-tracking branch 'upstream/master'
59584f0
@calvin681
Merge remote-tracking branch 'upstream/master'
cd430e6
@calvin681
Merge remote-tracking branch 'upstream/master'
23ac31b
@calvin681
Log mantisEventsDropped metric when there is an exception during proc…
e9776ba 
…essing
@calvin681
Default to creating a new Map
c61fdec
@calvin681
back to warn
0d667a7
@calvin681
add comment to explain deprecation
3177bc4
@calvin681
Merge remote-tracking branch 'upstream/master'
3213c46
@calvin681
Feeds backpressure back to drop operator on SSE connection
21117a9
@calvin681
Add test for serial consumption
18b2b4b
@calvin681
clean up test
44ea933
@calvin681
Merge remote-tracking branch 'upstream/master'
91c4985
@calvin681
Fix DataDrop metrics base on Counter semantics
6395e1a
@calvin681
Add license
b48b271
@calvin681
Merge remote-tracking branch 'upstream/master'
cb58e91
@calvin681
Allow integralDecay to be configured for ClutchRPS scaler via json
3fe2508
@calvin681
flip decay range
87aa028
@calvin681
more clear naming of vars
8e92997
@calvin681
race condition in test
429abf9
@calvin681
Merge remote-tracking branch 'upstream/master'
f010465
@calvin681
Fix clutch RPS to treat drop metric as a percentage of RPS
764fe19
@calvin681
Merge remote-tracking branch 'upstream/master'
fd26bea
@calvin681
Relocate all com.google classes in mantis-shaded
25f6b76
@calvin681 calvin681 self-assigned this Aug 23, 2021
@calvin681 calvin681 added the bug Something isn't working label Aug 23, 2021
@calvin681 calvin681 merged commit ba22284 into Netflix:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundargates sundargates sundargates approved these changes

@nickmahilani nickmahilani Awaiting requested review from nickmahilani

@piygoyal piygoyal Awaiting requested review from piygoyal

Assignees

@calvin681 calvin681

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calvin681 @sundargates