Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle nullptr on killJobRequest requestor #128

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Handle nullptr on killJobRequest requestor #128

merged 1 commit into from
Nov 11, 2021

Conversation

Andyz26
Copy link
Collaborator

@Andyz26 Andyz26 commented Nov 9, 2021 •
edited
Loading

Context

Handle null ptr exception for KillJobRequest.requestor. This can happen when the requestor is cluster manager actor itself e.g. worker resubmit count exceeded case.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable
  • Added copyright headers for new files from CONTRIBUTING.md

@Andyz26 Andyz26 merged commit 28ce730 into Netflix:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchao jeffchao jeffchao approved these changes

@calvin681 calvin681 calvin681 approved these changes

@nickmahilani nickmahilani Awaiting requested review from nickmahilani

@piygoyal piygoyal Awaiting requested review from piygoyal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andyz26 @calvin681 @jeffchao