Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only count resubmission from worker failures #142

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

calvin681
Copy link
Collaborator

@calvin681 calvin681 commented Mar 5, 2022

Context

If workers are resubmitted too frequently within a time period, the job is automatically terminated. However, there are scenarios where workers are supposed to be resubmitted, such as moving mesos clusters. We should only count resubmissions that are due to errors (worker is an error state and terminated unexpectedly).

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable
  • Added copyright headers for new files from CONTRIBUTING.md

Copy link
Contributor

@codyrioux codyrioux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants