Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to latest mantis-example and update commands #161

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

liuml07
Copy link
Contributor

@liuml07 liuml07 commented Apr 4, 2022

Context

The git repository mantis-examples has been deprecated and has been moved to the central mantis repository (this). However, example code and links in documentation are still pointing to the old mantis-example repository. That could be confusing when people follow the link only to find the stale code.

This patch fixes the deprecated links, and also updates the commands to run those example jobs.

NOTE: there could be other stale links as we have deprecated multiple standalone repositories and moved them here. We should file new pull requests to fix that. This one is mainly for mantis-examples.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable
  • Added copyright headers for new files from CONTRIBUTING.md

@liuml07 liuml07 self-assigned this Apr 4, 2022
@liuml07 liuml07 added the documentation Improvements or additions to documentation label Apr 4, 2022
Copy link
Collaborator

@hmitnflx hmitnflx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! ❤️

Copy link
Contributor

@codyrioux codyrioux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sundargates
Copy link
Collaborator

thank you for this change!

@liuml07 liuml07 merged commit 45d804d into master Apr 5, 2022
@liuml07 liuml07 deleted the mingliangl/improve-doc branch April 5, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants