Adding tests for Resource Cluster Actor #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundargates
requested review from
codyrioux,
nickmahilani,
jeffchao,
piygoyal,
calvin681,
Andyz26,
hmitnflx,
markcho and
liuml07
as code owners
calvin681
reviewed
Apr 13, 2022
| TaskExecutorReport.available())).get()); | ||
| assertEquals(TASK_EXECUTOR_ID, resourceCluster.getTaskExecutorFor(MACHINE_DEFINITION, WORKER_ID).get()); | ||
| assertEquals(ImmutableList.of(), resourceCluster.getAvailableTaskExecutors().get()); | ||
| Thread.sleep(2000); |
There was a problem hiding this comment.
should this be done using a mock Clock?
There was a problem hiding this comment.
I'm not sure if I can make Akka schedule something (such as the assignment timeout in this case) based on a mock clock. Let me take a look into this.
There was a problem hiding this comment.
It would be great if we could. All these Thread.sleep() start to add up over time.
codyrioux
approved these changes
Apr 13, 2022
| TaskExecutorReport.available())).get()); | ||
| assertEquals(TASK_EXECUTOR_ID, resourceCluster.getTaskExecutorFor(MACHINE_DEFINITION, WORKER_ID).get()); | ||
| assertEquals(ImmutableList.of(), resourceCluster.getAvailableTaskExecutors().get()); | ||
| Thread.sleep(2000); |
There was a problem hiding this comment.
It would be great if we could. All these Thread.sleep() start to add up over time.
sundargates
force-pushed
the
sundaram/titus_part16
branch
from
98c24d9
to
5f7de0d
Compare
sundargates
force-pushed
the
sundaram/titus_part16
branch
from
c88f852
to
6e1c241
Compare
cleaning the code Making tests run in serial Adding failure message Adding failure message Fixing flaky tests
sundargates
force-pushed
the
sundaram/titus_part16
branch
from
793495b
to
68bf289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This change purely has some additional tests for the resource cluster actor.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all testsCONTRIBUTING.md