Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading mantis-shaded #196

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Upgrading mantis-shaded #196

merged 1 commit into from
Apr 22, 2022

Conversation

sundargates
Copy link
Collaborator

Context

Explain context and other details for this pull request.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable
  • Added copyright headers for new files from CONTRIBUTING.md

codyrioux
codyrioux approved these changes Apr 22, 2022
View reviewed changes
build.gradle
@@ -66,7 +66,7 @@ ext.libraries = [
"org.junit.jupiter:junit-jupiter-engine:${versions.junit5}",
"org.junit.jupiter:junit-jupiter-params:${versions.junit5}",
],
mantisShaded : "io.mantisrx:mantis-shaded:1.+",
mantisShaded : "io.mantisrx:mantis-shaded:2.0.0-rc.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why an RC vs a release?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't released 2.0.0 yet. till then I at least want all deps to be 2.+ even if it's a rc release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@sundargates sundargates merged commit 96d0f24 into Netflix:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyrioux codyrioux codyrioux approved these changes

@liuml07 liuml07 liuml07 approved these changes

@nickmahilani nickmahilani Awaiting requested review from nickmahilani

@jeffchao jeffchao Awaiting requested review from jeffchao

@piygoyal piygoyal Awaiting requested review from piygoyal

@calvin681 calvin681 Awaiting requested review from calvin681 calvin681 is a code owner

@Andyz26 Andyz26 Awaiting requested review from Andyz26 Andyz26 is a code owner

@hmitnflx hmitnflx Awaiting requested review from hmitnflx hmitnflx is a code owner

@markcho markcho Awaiting requested review from markcho

@fdc-ntflx fdc-ntflx Awaiting requested review from fdc-ntflx fdc-ntflx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundargates @liuml07 @codyrioux