[ResourceCluster] Add basic host routes to v1 API. #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andyz26
requested review from
codyrioux,
nickmahilani,
jeffchao,
piygoyal,
calvin681,
sundargates,
hmitnflx,
markcho,
liuml07 and
fdc-ntflx
as code owners
codyrioux
approved these changes
Apr 25, 2022
| public class ResourceClustersPayloads { | ||
| public static final String CLUSTER_ID = "mantisResourceClusterUT1"; | ||
|
|
||
| public static final String RESOURCE_CLUSTER_CREATE = "{\"clusterId\":\"mantisResourceClusterUT1\",\"clusterSpec\":" |
There was a problem hiding this comment.
More of a personal preference than anything, but these may be painful to modify for testing if the data structure changes in any sort of meaningful way. Some kind of structure that gets serialized, or even a well formatted ".json" file that is read in would be easier to edit.
There was a problem hiding this comment.
+1. Moved to a resource JSON file.
| import io.mantisrx.control.plane.resource.cluster.proto.ScaleResourceResponse; | ||
| import java.util.concurrent.CompletionStage; | ||
|
|
||
| public interface ResourceClusterRouteHandler { |
There was a problem hiding this comment.
I may have missed some team discussion on this but do we have an official stance on interface names I ResourceClusterRouteHandler vs ResourceClusterRouteHandler? I don't have a strong opinion either way.
There was a problem hiding this comment.
This was brought up a few times in some of the previous PR comments from @sundargates IIRC and I am following his pattern in the new OSS mantis code at this point to be consistent.
| .mapAsync(1, rc -> updateRegisteredClusters(rc)) | ||
| .mapAsync(1, notUsed -> getRegisteredResourceClustersWritable()) | ||
| .runWith(Sink.last(), system); | ||
| log.info("Return future on deregisterCluster: {}", clusterId); |
There was a problem hiding this comment.
nit: Might be more appropriate to use trace or debug level here.
|
I’ll make sure to follow that pattern in my code too to maintain
consistency. :)
…On Mon, Apr 25, 2022 at 9:56 AM Andy Zhang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/master/api/akka/route/handlers/ResourceClusterRouteHandler.java
<#197 (comment)>:
> + * limitations under the License.
+ */
+
+package io.mantisrx.master.api.akka.route.handlers;
+
+import io.mantisrx.control.plane.resource.cluster.proto.GetResourceClusterSpecRequest;
+import io.mantisrx.control.plane.resource.cluster.proto.ListResourceClusterRequest;
+import io.mantisrx.control.plane.resource.cluster.proto.ProvisionResourceClusterRequest;
+import io.mantisrx.control.plane.resource.cluster.proto.ResourceClusterAPIProto.DeleteResourceClusterResponse;
+import io.mantisrx.control.plane.resource.cluster.proto.ResourceClusterAPIProto.GetResourceClusterResponse;
+import io.mantisrx.control.plane.resource.cluster.proto.ResourceClusterAPIProto.ListResourceClustersResponse;
+import io.mantisrx.control.plane.resource.cluster.proto.ScaleResourceRequest;
+import io.mantisrx.control.plane.resource.cluster.proto.ScaleResourceResponse;
+import java.util.concurrent.CompletionStage;
+
+public interface ResourceClusterRouteHandler {
This was brought up a few times in some of the previous PR comments from
@sundargates <https://github.com/sundargates> IIRC and I am following his
pattern in the new OSS mantis code at this point to be consistent.
—
Reply to this email directly, view it on GitHub
<#197 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACUD7Z57LPWIUK3PFTVKTTVG3FEVANCNFSM5UC6W5QQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add API for ResouceClustersHostActor public facing operations.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all testsCONTRIBUTING.md