Ensure there is only 1 subscription in PushTrigger #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvin681
requested review from
codyrioux,
nickmahilani,
jeffchao,
piygoyal,
sundargates,
Andyz26,
hmitnflx,
markcho,
liuml07 and
fdc-ntflx
as code owners
hmitnflx
approved these changes
Jul 15, 2022
codyrioux
approved these changes
Jul 15, 2022
|
|
||
| )); | ||
| // decouple from calling thread | ||
| .observeOn(Schedulers.computation()) |
There was a problem hiding this comment.
Thoughts on computation scheduler vs IO scheduler for this task?
There was a problem hiding this comment.
Actually I wonder why we need to specify a schedule at all. It can just run on whatever scheduler it's already running on. @hmitnflx do you know? Maybe I can just remove this line.
sundargates
approved these changes
Jul 18, 2022
| subscriptionActive.decrement(); | ||
| }) | ||
| .subscribe((T data) -> queue.write(data) | ||
| , |
There was a problem hiding this comment.
nit: move this to the previous line?
calvin681
added a commit
that referenced
this pull request
Jul 22, 2022
* Ensure there is only 1 subscription * clean up some formatting * fix scheduler Co-authored-by: Calvin Cheung <ccheung@netflix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There is an implicit assumption that subscription should be 1. Before, the subscriptionActive gauge is always set to 1 whenever there is at least 1 subscription. I change that to increment/decrement on subscribe/unsubscribe to more accurately reflect the number of subscriptions. Before, the unsubscribe was purposely commented out. Clearly, this can lead to multiple subscription, which violates the assumption. With this change, we will unsubscribe the old subscription when a new subscription is created. This should correct keep active subscription at 1.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all testsCONTRIBUTING.md