Support fallback blob store #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andyz26
requested review from
calvin681,
sundargates,
hmitnflx and
fdc-ntflx
as code owners
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
sundargates
reviewed
Sep 5, 2024
| @@ -67,6 +72,23 @@ static BlobStore forHadoopFileSystem(URI clusterStoragePath, File localStoreDir) | |||
| .withThreadSafeBlobStore(); | |||
| } | |||
|
|
|||
| static BlobStore forHadoopFileSystem(URI clusterStoragePath, URI fallbackStoragePath, File localStoreDir) | |||
There was a problem hiding this comment.
nit: why custom API for this?
There was a problem hiding this comment.
what do you mean by custom API? This is overloading the same API above with extra param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add support to a fallback blob store which will be used if the default storage cannot fetch the target file. This is used for blob store migration.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests