Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs in the AsyncPostgresDB initialization retry logic #439

Open
fumoboy007 opened this issue Sep 9, 2024 · 0 comments · May be fixed by #440
Open

Bugs in the AsyncPostgresDB initialization retry logic #439

fumoboy007 opened this issue Sep 9, 2024 · 0 comments · May be fixed by #440

Comments

@fumoboy007
Copy link

fumoboy007 commented Sep 9, 2024 •
edited
Loading

AsyncPostgresDB initializes a PostgreSQL connection pool. It has retry logic to handle initialization failures; however, there are a couple bugs in that logic:

  • Does not raise the exception when initialization fails.
  • Creates the connection pool multiple times even if it was already successful.
fumoboy007 added a commit to fumoboy007/metaflow-service that referenced this issue Sep 9, 2024
@fumoboy007
Fix AsyncPostgresDB initialization retry logic.
624d16d 
Fixes Netflix#439.
@fumoboy007 fumoboy007 linked a pull request Sep 9, 2024 that will close this issue
Open
@fumoboy007 fumoboy007 changed the title AsyncPostgresDB does not raise exception when initialization fails Bugs in the AsyncPostgresDB initialization retry logic Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix AsyncPostgresDB initialization retry logic fumoboy007/metaflow-service
1 participant
@fumoboy007