Fix: cache issues #292
Merged
Fix: cache issues #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
saikonen
commented
Jan 27, 2022
saikonen
commented
- Adds a check that tmpdir exists when launching workers, and creates the dir if it is missing. This fixes workers not being able to launch if for any reason the cache directory gets wiped.
- Adds log cache process to the cache healthcheck monitoring, so it will correctly be restarted in case of issues.
saikonen
added
ready-for-review
|
This fix is very much needed, the LogCacheStore tends to die after a while and the service requires a manual restart. Could someone please review? @oavdeev @obgibson @jackie-ob |
valayDave
approved these changes
Mar 18, 2024
valayDave
reviewed
Mar 18, 2024
| @@ -77,7 +77,7 @@ async def start_caches(self, app): | |||
|
|
|||
| async def _monitor_restart_requests(self): | |||
| while True: | |||
| for _cache in [self.artifact_cache, self.dag_cache]: | |||
There was a problem hiding this comment.
We should merge this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.